Issue 2006008: Create IS_SPEC_OBJECT macro to simplify javescript code....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2006008: Create IS_SPEC_OBJECT macro to simplify javescript code.... (Closed)

Created:
10 years, 7 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Create IS_SPEC_OBJECT macro to simplify javescript code. v8natives and runtime.js updated to use new macro and simplified when possible. Committed: http://code.google.com/p/v8/source/detail?r=4626

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -20 lines)			Patch
M	src/macros.py	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/runtime.js	View	1 2	5 chunks	+6 lines, -9 lines	0 comments	Download
M	src/v8natives.js	View	1 2	10 chunks	+10 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM, but reconsider the name (or functionality, if it should match the spec and not ...

10 years, 7 months ago (2010-05-10 08:47:17 UTC) #2

Rico

10 years, 7 months ago (2010-05-10 08:58:22 UTC) #3

http://codereview.chromium.org/2006008/diff/1004/2002
File src/macros.py (right):

http://codereview.chromium.org/2006008/diff/1004/2002#newcode116
src/macros.py:116: # "Type(O) is object."
On 2010/05/10 08:47:17, Lasse Reichstein wrote:
> That does not include the Null type, but %_IsObject(arg) does accept null
> arguments. I.e., this is really IS_SPEC_OBJECT_OR_NULL.
>
Good point - changed.

Expand Messages | Collapse Messages