Add dependencies for locales to TSan/Win build target

Add dependencies for locales to TSan/Win build target
BUG=43603
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47267

[Timur Iskhodzhanov, 2010-05-07 12:13:07]

If you try to clean & build "app_unittests only", app_unittests won't run
without them build\Debug\locales\*.dll files.

Probably a better idea would be to add these deps to app/app.gyp but this
requires build/all.gyp -> app.gyp -> chrome/ dependency
AFAIK app/->chrome/ dependencies are prohibited, right?

[bradn, 2010-05-07 17:38:29]

Yuck.
Yeah the way this is plumbed currently is really contorted.
chrome_exe --> locales --> chrome_resources + chrome_strings

The problem is that all the RC files have to get baked up together, and can't be
baked into a static library (at least I think they do, stupid windows resource
files...arg...).

What's missing is dependencies from each of the test targets that need the final
.res files to locales.gyp:* 
The * is kind of gross, but that's to avoid having to list out each locale.

Ah, but app_unittests needs it too.... yuck.

Uh, maybe do it this way, but add a nasty TODO to this file and locales.gyp
noting that msvs gyp needs a way to 'pretend' that .rc files are attached to
static_libraries so the dependencies can flow the right direction.

Sigh.. I'll also file a gyp issue.

[Timur Iskhodzhanov, 2010-05-07 19:40:37]

I've added a TODO and filed a bug
http://code.google.com/p/chromium/issues/detail?id=43603
Is this fine?
On 2010/05/07 17:38:29, bradn wrote:
> Yuck.
> Yeah the way this is plumbed currently is really contorted.
> chrome_exe --> locales --> chrome_resources + chrome_strings
> 
> The problem is that all the RC files have to get baked up together, and can't
be
> baked into a static library (at least I think they do, stupid windows resource
> files...arg...).
> 
> What's missing is dependencies from each of the test targets that need the
final
> .res files to locales.gyp:* 
> The * is kind of gross, but that's to avoid having to list out each locale.
> 
> Ah, but app_unittests needs it too.... yuck.
> 
> Uh, maybe do it this way, but add a nasty TODO to this file and locales.gyp
> noting that msvs gyp needs a way to 'pretend' that .rc files are attached to
> static_libraries so the dependencies can flow the right direction.
> 
> Sigh.. I'll also file a gyp issue.

[tony, 2010-05-10 01:23:16]

I fixed this on Linux by having it create a separate
app_unittests_strings/en-US.pak and having app_unittests use that instead of
locales/en-US.pak.  I think you should do something similar for Windows or Mac
since in the case of an upstream checkout, chrome doesn't exist so the tests
will just fail.  See r45294.

[bradn, 2010-05-11 05:22:32]

Tony's suggestion sounds wise.

-BradN

On Sun, May 9, 2010 at 6:23 PM, <tony@chromium.org> wrote:

> I fixed this on Linux by having it create a separate
> app_unittests_strings/en-US.pak and having app_unittests use that instead
> of
> locales/en-US.pak.  I think you should do something similar for Windows or
> Mac
> since in the case of an upstream checkout, chrome doesn't exist so the
> tests
> will just fail.  See r45294.
>
>
> http://codereview.chromium.org/2006006/show
>

[Timur Iskhodzhanov, 2010-05-14 11:46:28]

Tony,
I'm afraid I'm not the best person to do the 'full' fix for the app.gyp
Is it fine if I commit my workaround and re-assign the bug on you?

On 2010/05/11 05:22:32, bradn wrote:
> Tony's suggestion sounds wise.
> 
> -BradN
> 
> On Sun, May 9, 2010 at 6:23 PM, <mailto:tony@chromium.org> wrote:
> 
> > I fixed this on Linux by having it create a separate
> > app_unittests_strings/en-US.pak and having app_unittests use that instead
> > of
> > locales/en-US.pak.  I think you should do something similar for Windows or
> > Mac
> > since in the case of an upstream checkout, chrome doesn't exist so the
> > tests
> > will just fail.  See r45294.

[tony, 2010-05-14 11:52:08]

This change is only for the tsan win bots?  I guess it's ok, but I won't be able
to fix this for a couple months since I don't have access to a windows machine
right now.

[Timur Iskhodzhanov, 2010-05-14 12:01:05]

Yes, TSan/Win only.
Looks like not very much other people are affected by the bug.

Regarding Windows machine - probably you can ask Marc-Antoine to give you an
access to one Win box.

On 2010/05/14 11:52:08, tony wrote:
> This change is only for the tsan win bots?  I guess it's ok, but I won't be
able
> to fix this for a couple months since I don't have access to a windows machine
> right now.

[tony, 2010-05-14 12:13:26]

On 2010/05/14 12:01:05, Timur Iskhodzhanov wrote:
> Yes, TSan/Win only.
> Looks like not very much other people are affected by the bug.

Ok, LGTM.