Minor debugger cleanup. Store the running state of the previous debugger resp...

src/debug-delay.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 927 matching lines @@
 };
 
 
 NewFunctionEvent.prototype.setBreakPoint = function(p) {
   Debug.setBreakPoint(this.func, p || 0);
 };
 
 
 function DebugCommandProcessor(exec_state) {
   this.exec_state_ = exec_state;
+  this.running_ = false;
 };
 
 
 DebugCommandProcessor.prototype.processDebugRequest = function (request) {
   return this.processDebugJSONRequest(request);
 }
 
 
-DebugCommandProcessor.prototype.responseIsRunning = function (response) {
-  return this.isRunning(response);
-}
-
-
 function ResponsePacket(request) {
   // Build the initial response from the request.
   this.seq = next_response_seq++;
   this.type = 'response';
   if (request) this.request_seq = request.seq;
   if (request) this.command = request.command;
   this.success = true;
   this.running = false;
 }
 
@@ skipping 54 matching lines @@
   json += '}';
   return json;
 }
 
 
 DebugCommandProcessor.prototype.createResponse = function(request) {
   return new ResponsePacket(request);
 };
 
 
-DebugCommandProcessor.prototype.processDebugJSONRequest = function(json_request, stopping) {
+DebugCommandProcessor.prototype.processDebugJSONRequest = function(json_request) {
   var request;  // Current request.
   var response;  // Generated response.
   try {
     try {
       // Convert the JSON string to an object.
       request = %CompileString('(' + json_request + ')', 0)();
 
       // Create an initial response.
       response = this.createResponse(request);
 
@@ skipping 38 matching lines @@
       // If there is no response object created one (without command).
       if (!response) {
         response = this.createResponse();
       }
       response.success = false;
       response.message = %ToString(e);
     }
 
     // Return the response as a JSON encoded string.
     try {
-      // Set the running state to what indicated.
-      if (!IS_UNDEFINED(stopping)) {
-        response.running = !stopping;
-      }
+      this.running_ = response.running;  // Store the running state.
       return response.toJSONProtocol();
     } catch (e) {
       // Failed to generate response - return generic error.
       return '{"seq":' + response.seq + ',' +
               '"request_seq":' + request.seq + ',' +
               '"type":"response",' +
               '"success":false,' +
               '"message":"Internal error: ' + %ToString(e) + '"}';
     }
   } catch (e) {
@@ skipping 423 matching lines @@
       script.lineCount = scripts[i].lineCount();
       script.sourceStart = scripts[i].source.substring(0, 80);
       script.sourceLength = scripts[i].source.length;
       script.type = scripts[i].type;
       response.body.push(script);
     }
   }
 };
 
 
-// Check whether the JSON response indicate that the VM should be running.
-DebugCommandProcessor.prototype.isRunning = function(json_response) {
-  try {
-    // Convert the JSON string to an object.
-    response = %CompileString('(' + json_response + ')', 0)();
-
-    // Return whether VM should be running after this request.
-    return response.running;
-
-  } catch (e) {
-     return false;
-  }
+// Check whether the previously processed command caused the VM to become
+// running.
+DebugCommandProcessor.prototype.isRunning = function() {
+  return this.running_;
 }
 
 
 DebugCommandProcessor.prototype.systemBreak = function(cmd, args) {
   return %SystemBreak();
 };
 
 
 function NumberToHex8Str(n) {
   var r = "";
@@ skipping 115 matching lines @@
       json += NumberToJSON_(elem);
     } else if (IS_STRING(elem)) {
       json += StringToJSON_(elem);
     } else {
       json += elem;
     }
   }
   json += ']';
   return json;
 }