Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2003001: Add time for when chrome's main() is called. (Closed)

Created:
10 years, 7 months ago by DaveMoore
Modified:
9 years, 7 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add time for when chrome's main() is called. Also output chrome's time to launch on the login screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46526

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -9 lines) Patch
M chrome/app/chrome_dll_main.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/boot_times_loader.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 3 chunks +12 lines, -0 lines 1 comment Download
M chrome/browser/chromeos/login/background_view.cc View 1 chunk +25 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
DaveMoore
10 years, 7 months ago (2010-05-05 22:25:50 UTC) #1
sky
LGTM http://codereview.chromium.org/2003001/diff/1/3 File chrome/browser/chromeos/boot_times_loader.cc (right): http://codereview.chromium.org/2003001/diff/1/3#newcode13 chrome/browser/chromeos/boot_times_loader.cc:13: #include "base/file_util.h" before message_loop.
10 years, 7 months ago (2010-05-05 23:32:21 UTC) #2
oshima
Dave, chromeos bot started failing between r46523 and r46526, and this may be culprit. Can ...
10 years, 7 months ago (2010-05-06 08:28:21 UTC) #3
Sandeep
This check-in is breaking the build on tegra with below error message: cc1plus: warnings being ...
10 years, 7 months ago (2010-05-06 13:24:07 UTC) #4
Nikita (slow)
I've got fix for browser_tests that hang: http://codereview.chromium.org/2035002/show
10 years, 7 months ago (2010-05-06 13:31:44 UTC) #5
davemoore (google)
We can handle this in a much smaller way by just checking if the file ...
10 years, 7 months ago (2010-05-06 14:34:35 UTC) #6
xiyuan
10 years, 7 months ago (2010-05-06 17:08:37 UTC) #7
FYI, the compilation error mentioned by Sandeep happens inside chroot and it
happens to me for x86-generic board as well.

Powered by Google App Engine
This is Rietveld 408576698