Issue 2002015: Fix missing variable name in exception handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2002015: Fix missing variable name in exception handler. (Closed)

Created:
10 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Visibility:
Public.

Description

Fix missing variable name in exception handler. TEST=should stop throwing an exception when retrying for git checkouts BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46960

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gclient_scm.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw at google

10 years, 7 months ago (2010-05-11 20:59:15 UTC) #3

LGTM

On Tue, May 11, 2010 at 1:54 PM,  <maruel@chromium.org> wrote:
> Reviewers: brett_chromium.org,
>
> Description:
> Fix missing variable name in exception handler.
>
> TEST=should stop throwing an exception when retrying for git checkouts
> BUG=none
>
> Please review this at http://codereview.chromium.org/2002015/show
>
> Affected files:
>  M gclient_scm.py
>
>
> Index: gclient_scm.py
> diff --git a/gclient_scm.py b/gclient_scm.py
> index
>
e51a0eecb254bb47d937bc64347db6519350b340..3a0b5371ce68198bd32483c4d0a9406952e14819
> 100644
> --- a/gclient_scm.py
> +++ b/gclient_scm.py
> @@ -260,7 +260,7 @@ class GitWrapper(SCMWrapper):
>             self.checkout_path,
>             print_error=False)
>         break
> -      except gclient_utils.CheckCallError:
> +      except gclient_utils.CheckCallError, e:
>         # Hackish but at that point, git is known to work so just checking
> for
>         # 502 in stderr should be fine.
>         if '502' in e.stderr:
>
>
>

Expand Messages | Collapse Messages