Issue 2002: Fix performace regression due to missed peephole optimization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2002: Fix performace regression due to missed peephole optimization (Closed)

Created:
12 years, 3 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix performace regression due to missed peephole optimization opportunity. Committed: http://code.google.com/p/v8/source/detail?r=286

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	src/codegen-arm.cc	View		3 chunks	+5 lines, -1 line	1 comment	Download
	M	src/codegen-ia32.cc	View		3 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iposva

12 years, 3 months ago (2008-09-11 18:25:10 UTC) #2

I know this has been committed...

-Ivan

http://codereview.chromium.org/2002/diff/1/2
File src/codegen-arm.cc (right):

http://codereview.chromium.org/2002/diff/1/2#newcode988
Line 988: if (skipped_write) masm->bind(&exit);
Why do you introduce a separate variable for testing (init_state == CONST_INIT)?
In my opinion that is more confusing. Same for ia32.

Expand Messages | Collapse Messages