Added check for logging enabled in two places where processing/allocation was...

src/compiler.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 103 matching lines @@
 
   // Compile the code.
   Handle<Code> code = MakeCode(lit, script, is_eval);
 
   // Check for stack-overflow exceptions.
   if (code.is_null()) {
     Top::StackOverflow();
     return Handle<JSFunction>::null();
   }
 
-  if (script->name()->IsString()) {
-    SmartPointer<char> data =
-        String::cast(script->name())->ToCString(DISALLOW_NULLS);
-    LOG(CodeCreateEvent(is_eval ? "Eval" : "Script", *code, *data));
-  } else {
-    LOG(CodeCreateEvent(is_eval ? "Eval" : "Script", *code, ""));
+#ifdef ENABLE_LOGGING_AND_PROFILING
+  // Log the code generation for the script. Check explicit whether logging is
+  // to avoid allocating when not required.
+  if (Logger::is_enabled()) {
+    if (script->name()->IsString()) {
+      SmartPointer<char> data =
+          String::cast(script->name())->ToCString(DISALLOW_NULLS);
+      LOG(CodeCreateEvent(is_eval ? "Eval" : "Script", *code, *data));
+    } else {
+      LOG(CodeCreateEvent(is_eval ? "Eval" : "Script", *code, ""));
+    }
   }
+#endif
 
   // Allocate function.
   Handle<JSFunction> fun =
       Factory::NewFunctionBoilerplate(lit->name(),
                                       lit->materialized_literal_count(),
                                       lit->contains_array_literal(),
                                       code);
 
   CodeGenerator::SetFunctionInfo(fun, lit->scope()->num_parameters(),
                                  RelocInfo::kNoPosition,
@@ skipping 144 matching lines @@
 
   // Compile the code.
   Handle<Code> code = MakeCode(lit, script, false);
 
   // Check for stack-overflow exception.
   if (code.is_null()) {
     Top::StackOverflow();
     return false;
   }
 
-  // Generate the code, update the function info, and return the code.
 #ifdef ENABLE_LOGGING_AND_PROFILING
-  if (script->name()->IsString()) {
-    int lineNum = script->GetLineNumber(start_position);
-    if (lineNum > 0) {
-      lineNum += script->line_offset()->value() + 1;
+  // Log the code generation. If source information is available include script
+  // name and line number. Check explicit whether logging is enabled as finding
+  // the line number is not for free.
+  if (Logger::is_enabled()) {
+    if (script->name()->IsString()) {
+      int lineNum = script->GetLineNumber(start_position);
+      if (lineNum > 0) {
+        lineNum += script->line_offset()->value() + 1;
+      }
+      LOG(CodeCreateEvent("LazyCompile", *code, *lit->name(),
+                          String::cast(script->name()), lineNum));
+    } else {
+      LOG(CodeCreateEvent("LazyCompile", *code, *lit->name()));
     }
-    LOG(CodeCreateEvent("LazyCompile", *code, *lit->name(),
-                        String::cast(script->name()), lineNum));
-  } else {
-    LOG(CodeCreateEvent("LazyCompile", *code, *lit->name()));
   }
 #endif
 
   // Update the shared function info with the compiled code.
   shared->set_code(*code);
 
   // Set the expected number of properties for instances.
   SetExpectedNofPropertiesFromEstimate(shared, lit->expected_property_count());
 
   // Check the function has compiled code.
   ASSERT(shared->is_compiled());
   return true;
 }
 
 
 } }  // namespace v8::internal