Unescape FTP URL paths, Firefox-compatible.

net/ftp/ftp_network_transaction_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_network_transaction.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <ws2tcpip.h>
@@ skipping 184 matching lines @@
     if (InjectFault())
       return MockWriteResult(true, data.length());
     switch (state()) {
       case PRE_SIZE:
         return Verify("SIZE /file\r\n", data, PRE_MDTM,
                       "213 18\r\n");
       case PRE_MDTM:
         return Verify("MDTM /file\r\n", data, PRE_RETR,
                       "213 20070221112533\r\n");
       case PRE_RETR:
-        // TODO(phajdan.jr): Also test with "150 Accepted Data Connection".
         return Verify("RETR /file\r\n", data, PRE_QUIT, "200 OK\r\n");
       default:
         return FtpMockControlSocket::OnWrite(data);
     }
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FtpMockControlSocketFileDownload);
 };
 
+class FtpMockControlSocketEscaping : public FtpMockControlSocket {
+ public:
+  FtpMockControlSocketEscaping() {
+  }
+
+  virtual MockWriteResult OnWrite(const std::string& data) {
+    if (InjectFault())
+      return MockWriteResult(true, data.length());
+    switch (state()) {
+      case PRE_SIZE:
+        return Verify("SIZE / !\"#$%y\200\201\r\n", data, PRE_MDTM,
+                      "213 18\r\n");
+      case PRE_MDTM:
+        return Verify("MDTM / !\"#$%y\200\201\r\n", data, PRE_RETR,
+                      "213 20070221112533\r\n");
+      case PRE_RETR:
+        return Verify("RETR / !\"#$%y\200\201\r\n", data, PRE_QUIT,
+                      "200 OK\r\n");
+      default:
+        return FtpMockControlSocket::OnWrite(data);
+    }
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(FtpMockControlSocketEscaping);
+};
+
 class FtpMockControlSocketFileDownloadAcceptedDataConnection
     : public FtpMockControlSocketFileDownload {
  public:
   FtpMockControlSocketFileDownloadAcceptedDataConnection() {
   }
 
   virtual MockWriteResult OnWrite(const std::string& data) {
     if (InjectFault())
       return MockWriteResult(true, data.length());
     switch (state()) {
@@ skipping 450 matching lines @@
     MockWrite("QUIT\r\n"),
   };
   StaticMockSocket ctrl_socket2(ctrl_reads, ctrl_writes);
   mock_socket_factory_.AddMockSocket(&ctrl_socket2);
   ASSERT_EQ(ERR_IO_PENDING, transaction_.RestartWithAuth(L"innocent",
                                                          L"foo\nownz0red",
                                                          &callback_));
   EXPECT_EQ(ERR_MALFORMED_IDENTITY, callback_.WaitForResult());
 }
 
+TEST_F(FtpNetworkTransactionTest, Escaping) {
+  FtpMockControlSocketEscaping ctrl_socket;
+  ExecuteTransaction(&ctrl_socket, "ftp://host/%20%21%22%23%24%25%79%80%81",
+                     OK);
+}
+
 TEST_F(FtpNetworkTransactionTest, DirectoryTransactionFailUser) {
   FtpMockControlSocketDirectoryListing ctrl_socket;
   TransactionFailHelper(&ctrl_socket,
                         "ftp://host",
                         FtpMockControlSocket::PRE_USER,
                         FtpMockControlSocket::PRE_QUIT,
                         "500 no such user\r\n",
                         ERR_FAILED);
 }
 
@@ skipping 181 matching lines @@
   FtpMockControlSocketFileDownloadRetrFail ctrl_socket;
   TransactionFailHelper(&ctrl_socket,
                         "ftp://host/file",
                         FtpMockControlSocket::PRE_RETR,
                         FtpMockControlSocket::PRE_CWD,
                         "550 cannot open file\r\n",
                         ERR_FILE_NOT_FOUND);
 }
 
 }  // namespace net