Issue 200144: Make follow-up changes per r26302 review comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200144: Make follow-up changes per r26302 review comments (Closed)

Created:
11 years, 3 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL, yaar

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make follow-up changes per r26302 review comments that were apparently not made in r26302. Set Subversion properties, fix the O3D GYP invocation to work properly, fix presubmit warnings, and do some additional cleanup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26378

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -20 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
MM	build/gyp_chromium	View	1	2 chunks	+17 lines, -8 lines	0 comments	Download
M	o3d/DEPS_gyp	View		1 chunk	+3 lines, -4 lines	0 comments	Download
MM	o3d/build/gyp_o3d	View	1	1 chunk	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages