Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 200142: Use URL constants instead of writing string literals. (Closed)

Created:
11 years, 3 months ago by tyoshino (SeeGerritForStatus)
Modified:
9 years, 7 months ago
Reviewers:
James Su
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Paweł Hajdan Jr.
Visibility:
Public.

Description

Use URL constants instead of writing string literals in test using history page address. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27172

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tyoshino (SeeGerritForStatus)
11 years, 3 months ago (2009-09-17 07:53:59 UTC) #1
James Su
LGTM. Thanks a lot to help fix it. James Su
11 years, 3 months ago (2009-09-17 08:02:18 UTC) #2
tyoshino (SeeGerritForStatus)
11 years, 3 months ago (2009-09-25 03:46:29 UTC) #3
Thanks for review.

Powered by Google App Engine
This is Rietveld 408576698