Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/browser/gtk/tabs/tab_gtk.cc

Issue 200122: Remove code doing a no-op due to float -> int rounding. (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/tabs/dragged_tab_gtk.cc ('k') | chrome/renderer/print_web_view_helper_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/tabs/tab_gtk.cc
diff --git a/chrome/browser/gtk/tabs/tab_gtk.cc b/chrome/browser/gtk/tabs/tab_gtk.cc
index 667cd8a71df83eeac0183746ca50001387a81df3..ca9b93dbadbd2de28c80c509a98981d05cf08e8d 100644
--- a/chrome/browser/gtk/tabs/tab_gtk.cc
+++ b/chrome/browser/gtk/tabs/tab_gtk.cc
@@ -227,10 +227,14 @@ void TabGtk::DidProcessEvent(GdkEvent* event) {
GdkEventMotion* motion = reinterpret_cast<GdkEventMotion*>(event);
GdkEventButton* button = reinterpret_cast<GdkEventButton*>(last_mouse_down_);
bool dragging = gtk_drag_check_threshold(widget(),
- button->x, button->y,
- motion->x, motion->y);
- if (dragging)
- StartDragging(gfx::Point(button->x, button->y));
+ static_cast<gint>(button->x),
+ static_cast<gint>(button->y),
+ static_cast<gint>(motion->x),
+ static_cast<gint>(motion->y));
+ if (dragging) {
+ StartDragging(gfx::Point(static_cast<int>(button->x),
+ static_cast<int>(button->y)));
+ }
}
///////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « chrome/browser/gtk/tabs/dragged_tab_gtk.cc ('k') | chrome/renderer/print_web_view_helper_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698