gcl.py - Issue 200103: Making gcl upload do tryupload from the same place as gcl try....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcl.py

Issue 200103: Making gcl upload do tryupload from the same place as gcl try.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gcl.py

===================================================================

--- gcl.py (revision 25888)

+++ gcl.py (working copy)

@@ -853,6 +853,10 @@

# ready when the issue is viewed.

SendToRietveld("/lint/issue%s_%s" % (issue, patchset), timeout=0.5)

+ # Move back before considering try, so GetCodeReviewSettings is

+ # consistent.

+ os.chdir(previous_cwd)

# Once uploaded to Rietveld, send it to the try server.

if not no_try:

try_on_upload = GetCodeReviewSetting('TRY_ON_UPLOAD')

@@ -862,7 +866,6 @@

trychange_args.append('--clobber')

TryChange(change_info, trychange_args, swallow_exception=True)

- os.chdir(previous_cwd)

def PresubmitCL(change_info):

« no previous file with comments | « no previous file | no next file » | no next file with comments »