Some scaffolding for the task manager.

Some scaffolding for the task manager.

BUG=13156
TEST=Connect view->task manager to first responder's commandDispatch: and give the menu item the tag 40005. Now clicking that menu item should bring up a completely unfunctional task manager window (but it has a localized title and button).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26278

[Nico, 2009-09-11 12:09:01]

I'm trying a more iterative approach for the task manager, so this CL does not
do a lot. I intend to check this in without the MainMenu.xib change, so that
users won't be able to see the work-in-progress task manager.

[pink (ping after 24hrs), 2009-09-14 16:52:14]

I know this doesn't do much yet, but when you add a new file you should always
add a unit test for it. When the next iteration comes by, the reviewer might not
check since it's not a new file and then we'll forget to go back later and add
it.

http://codereview.chromium.org/200094/diff/1/6
File chrome/browser/cocoa/task_manager_mac.h (right):

http://codereview.chromium.org/200094/diff/1/6#newcode14
Line 14: @interface TaskManagerWindowController : NSWindowController {
unit test?

http://codereview.chromium.org/200094/diff/1/6#newcode39
Line 39: TaskManager* task_manager_;
are these strong or weak? If strong, why not make them scoped_ptrs? If they're
weak, comment as such.

http://codereview.chromium.org/200094/diff/1/6#newcode42
Line 42: TaskManagerModel* model_;
same here

[Nico, 2009-09-15 07:15:43]

http://codereview.chromium.org/200094/diff/1/6
File chrome/browser/cocoa/task_manager_mac.h (right):

http://codereview.chromium.org/200094/diff/1/6#newcode14
Line 14: @interface TaskManagerWindowController : NSWindowController {
Added the most basic test there is.

http://codereview.chromium.org/200094/diff/1/6#newcode39
Line 39: TaskManager* task_manager_;
On 2009/09/14 16:52:14, pink wrote:
> are these strong or weak? If strong, why not make them scoped_ptrs? If they're
> weak, comment as such.

Done.

http://codereview.chromium.org/200094/diff/1/6#newcode42
Line 42: TaskManagerModel* model_;
On 2009/09/14 16:52:14, pink wrote:
> same here

Done.

[pink (ping after 24hrs), 2009-09-15 19:32:03]

LGTM

http://codereview.chromium.org/200094/diff/2024/4022
File chrome/browser/cocoa/task_manager_mac_unittest.mm (right):

http://codereview.chromium.org/200094/diff/2024/4022#newcode29
Line 29: }  // namespace
add TODOs for things like TaskManager::Show(), etc etc. I don't know the rest of
the API that you'll be implementing. Is there a Hide() as well? You should have
a test for those at some point.