Issue 200093: Make int64 -> Time conversion explicit....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200093: Make int64 -> Time conversion explicit.... (Closed)

Created:
11 years, 3 months ago by Jacob Mandelson

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, brettw, jacob_mandelson.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Make int64 -> Time conversion explicit. BUG=none TEST=base_unittests & app_unittests

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
M	base/time.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	base/time.cc	View	1 2	3 chunks	+5 lines, -4 lines	0 comments	Download
M	base/time_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

Jacob Mandelson

(Split off from CL 171028) Ran tests on Linux. Passed except for ConditionVariableTest.LargeFastTaskTest, which also ...

11 years, 3 months ago (2009-09-11 04:52:12 UTC) #1

Paweł Hajdan Jr.

LGTM. I'm going to wait for Mark's comments and can handle the landing for you.

11 years, 3 months ago (2009-09-11 15:47:01 UTC) #2

Mark Mentovai

LGTM. I don't see a trybot run, make sure it's had one. http://codereview.chromium.org/200093/diff/2001/2004 File base/time.cc ...

11 years, 3 months ago (2009-09-11 16:15:51 UTC) #3

Paweł Hajdan Jr.

I'll handle landing this. Sent to try servers.

11 years, 3 months ago (2009-09-14 16:39:53 UTC) #5

Paweł Hajdan Jr.

11 years, 3 months ago (2009-09-14 19:34:37 UTC) #6

Landed in http://codereview.chromium.org/205003, thanks for the patch.