Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 200080: Force preferences to save immediately when a theme is set, so that a browser ... (Closed)

Created:
11 years, 3 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Force preferences to save immediately when a theme is set, so that a browser crash does not corrupt the theme. BUG= http://crbug.com/21488 TEST= Install a theme. Force browser crash, and reopen. Note that theme images are not corrupted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25902

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/browser_theme_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Miranda Callahan
11 years, 3 months ago (2009-09-10 19:17:32 UTC) #1
Glen Murphy
11 years, 3 months ago (2009-09-10 19:23:05 UTC) #2
woot, LGTM

Powered by Google App Engine
This is Rietveld 408576698