Adding a project selection option to gcl....

Adding a project selection option to gcl.
Defaulting to a value in codereview.settings

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25886

[M-A Ruel, 2009-09-10 18:18:16]

http://codereview.chromium.org/200078/diff/1/2
File trychange.py (right):

http://codereview.chromium.org/200078/diff/1/2#newcode94
Line 94: settings['default_project'] =
gcl.GetCodeReviewSetting('TRYSERVER_PROJECT')
I'm not sure about this one, can you give a use case?

http://codereview.chromium.org/200078/diff/1/2#newcode437
Line 437: group.add_option("--project", help="Override which project to use",
I usually try to hide help until implemented server side

[bradn, 2009-09-10 18:26:00]

http://codereview.chromium.org/200078/diff/1/2
File trychange.py (right):

http://codereview.chromium.org/200078/diff/1/2#newcode94
Line 94: settings['default_project'] =
gcl.GetCodeReviewSetting('TRYSERVER_PROJECT')
On 2009/09/10 18:18:16, Marc-Antoine Ruel wrote:
> I'm not sure about this one, can you give a use case?

I'm imagining that with nacl + o3d + chrome on a single try master that they
would want to default to triggering a try build of just their component.

Was this not what you'd had in mind when we chatted a while back?

http://codereview.chromium.org/200078/diff/1/2#newcode437
Line 437: group.add_option("--project", help="Override which project to use",
On 2009/09/10 18:18:16, Marc-Antoine Ruel wrote:
> I usually try to hide help until implemented server side

Done.

[M-A Ruel, 2009-09-10 18:28:51]

general memory failure.

lgtm