Issue 200056: Made function prototype property DontEnum for compatibility with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200056: Made function prototype property DontEnum for compatibility with (Closed)

Created:
11 years, 3 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Visibility:
Public.

Description

Made function prototype property DontEnum for compatibility with Safari. Fixed const error in api.

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	include/v8.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/function-prototype.js	View	1 chunk	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/200056/diff/1/4 File test/mjsunit/function-prototype.js (right): http://codereview.chromium.org/200056/diff/1/4#newcode93 Line 93: // Check the prototype is not enumerable, ...

11 years, 3 months ago (2009-09-09 09:26:38 UTC) #2

Christian Plesner Hansen

11 years, 3 months ago (2009-09-09 09:30:51 UTC) #3

http://codereview.chromium.org/200056/diff/1/4
File test/mjsunit/function-prototype.js (right):

http://codereview.chromium.org/200056/diff/1/4#newcode93
Line 93: // Check the prototype is not enumerable, for compatibility with safari
Done.

Expand Messages | Collapse Messages