Issue 200055: Add MAP_FIXED to Uncommit calls to see if that has an effect on GMail...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200055: Add MAP_FIXED to Uncommit calls to see if that has an effect on GMail... (Closed)

Created:
11 years, 3 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
mseaborn - please use other, Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Add MAP_FIXED to Uncommit calls to see if that has an effect on GMail memory usage in Chromium 64-bit Linux. Committed: http://code.google.com/p/v8/source/detail?r=2848

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	src/platform-freebsd.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-macos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Erik Corry

LGTM. We should also test the return value of munmap in OS::Free. Perhaps assert it?

11 years, 3 months ago (2009-09-09 07:32:13 UTC) #2

Mads Ager (chromium)

On 2009/09/09 07:32:13, Erik Corry wrote: > LGTM. > > We should also test the ...

11 years, 3 months ago (2009-09-09 07:47:33 UTC) #3

mseaborn - please use other

11 years, 2 months ago (2009-10-19 17:30:13 UTC) #4

Note that this change was made (I think) in response to this Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=21041