Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: webkit/glue/plugins/plugin_lib.h

Issue 200052: linux: rewrite mime parser (Closed)
Patch Set: review comments Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/plugins/plugin_lib_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/plugins/plugin_lib.h
diff --git a/webkit/glue/plugins/plugin_lib.h b/webkit/glue/plugins/plugin_lib.h
index aad3f56b9baf2f7094e6da11571434116e3b2f23..ed523c124af7a4ba658b80eaaa98a7bc5a3833c3 100644
--- a/webkit/glue/plugins/plugin_lib.h
+++ b/webkit/glue/plugins/plugin_lib.h
@@ -36,10 +36,9 @@ class PluginLib : public base::RefCounted<PluginLib> {
static bool ReadWebPluginInfo(const FilePath& filename, WebPluginInfo* info);
#if defined(OS_LINUX)
- // Parse the result of an NP_GetMIMEDescription() call, returning
- // false on parse error. This API is only used on Linux, and is
- // exposed here for testing.
- static bool ParseMIMEDescription(const char* description,
+ // Parse the result of an NP_GetMIMEDescription() call.
+ // This API is only used on Linux, and is exposed here for testing.
+ static void ParseMIMEDescription(const std::string& description,
std::vector<WebPluginMimeType>* mime_types);
#endif
« no previous file with comments | « no previous file | webkit/glue/plugins/plugin_lib_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698