Issue 200050: [Mac] Force-enable the find next/previous buttons when pressing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200050: [Mac] Force-enable the find next/previous buttons when pressing... (Closed)

Created:
11 years, 3 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Force-enable the find next/previous buttons when pressing Cmd-F to repeat a search. BUG=http://crbug.com/18762 BUG=http://crbug.com/20273 TEST=See test cases in bugs. Both should work now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25722

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/find_bar_cocoa_controller.mm	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

LGTM. Are there other cases where we need to do this enabling as well?

11 years, 3 months ago (2009-09-09 14:54:21 UTC) #2

rohitrao (ping after 24h)

11 years, 3 months ago (2009-09-09 14:58:35 UTC) #3

On 2009/09/09 14:54:21, pink wrote:
> LGTM. Are there other cases where we need to do this enabling as well?

This is all I can see for now, and there aren't any other bugs filed, although I
wouldn't be terribly surprised if other cases turned up.

Expand Messages | Collapse Messages