Use Scoped[Bstr,ComPtr,Variant] instead of their ATL equivalents to reduce de...

chrome/browser/history/history_publisher_win.cc

 // Copyright (c) 2008-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/history_publisher.h"
 
 #include <atlsafe.h>
 #include <objbase.h>
 #include <oleauto.h>
 #include <wtypes.h>
 
 #include "base/registry.h"
+#include "base/scoped_bstr_win.h"
 #include "base/scoped_comptr_win.h"
+#include "base/scoped_variant_win.h"
+#include "base/string_util.h"
 #include "base/time.h"
 #include "googleurl/src/gurl.h"
 
 namespace {
 
 // Instantiates a IChromeHistoryIndexer COM object. Takes a COM class id
 // in |name| and returns the object in |indexer|. Returns false if the
 // operation fails.
 bool CoCreateIndexerFromName(const wchar_t* name,
                              IChromeHistoryIndexer** indexer) {
@@ skipping 76 matching lines @@
                         kRegKeyRegisteredIndexersInfo, &indexers_);
   return indexers_.size() > 0;
 }
 
 void HistoryPublisher::PublishDataToIndexers(const PageData& page_data)
     const {
   double var_time = TimeToUTCVariantTime(page_data.time);
 
   CComSafeArray<unsigned char> thumbnail_arr;
   if (page_data.thumbnail) {
-    for(size_t i = 0; i < page_data.thumbnail->size(); ++i)
+    for (size_t i = 0; i < page_data.thumbnail->size(); ++i)
       thumbnail_arr.Add((*page_data.thumbnail)[i]);
   }
 
   // Send data to registered indexers.
-  for(size_t i = 0; i < indexers_.size(); ++i) {
-    indexers_[i]->SendPageData(
-        CComVariant(var_time, VT_DATE),
-        CComBSTR(page_data.url.spec().c_str()),
-        CComBSTR(page_data.html),
-        CComBSTR(page_data.title),
-        CComBSTR(page_data.thumbnail_format),
-        CComVariant(thumbnail_arr.m_psa));
+  ScopedVariant time(var_time, VT_DATE);

[tommi (sloooow) - chröme, 2009/09/10 20:22:42]

one more absolute nit...
you might want to surround this entire block and the one in
DeleteUserHistoryBetween() with an

if (indexers_.size()) {
  ...
}

that way we're close to zero cycles for the most common case :)

thanks again for doing this.

+  ScopedBstr url(ASCIIToWide(page_data.url.spec()).c_str());
+  ScopedBstr html(page_data.html);
+  ScopedBstr title(page_data.title);
+  ScopedBstr format(ASCIIToWide(page_data.thumbnail_format).c_str());
+  ScopedVariant psa(thumbnail_arr.m_psa);
+  for (size_t i = 0; i < indexers_.size(); ++i) {
+    indexers_[i]->SendPageData(time, url, html, title, format, psa);
   }
 }
 
 void HistoryPublisher::DeleteUserHistoryBetween(const base::Time& begin_time,
                                                 const base::Time& end_time)
     const {
-  double var_begin_time = TimeToUTCVariantTime(begin_time);
-  double var_end_time = TimeToUTCVariantTime(end_time);
-  for(size_t i = 0; i < indexers_.size(); ++i) {
-    indexers_[i]->DeleteUserHistoryBetween(CComVariant(var_begin_time, VT_DATE),
-                                           CComVariant(var_end_time, VT_DATE));
+  ScopedVariant var_begin_time(TimeToUTCVariantTime(begin_time), VT_DATE);
+  ScopedVariant var_end_time(TimeToUTCVariantTime(end_time), VT_DATE);
+  for (size_t i = 0; i < indexers_.size(); ++i) {
+    indexers_[i]->DeleteUserHistoryBetween(var_begin_time, var_end_time);
   }
 }
 
 }  // namespace history