Issue 200040: DevTools: fix flakiness of DevToolsSanityTest/TestProfilerTab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200040: DevTools: fix flakiness of DevToolsSanityTest/TestProfilerTab. (Closed)

Created:
11 years, 3 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

DevTools: fix flakiness of DevToolsSanityTest/TestProfilerTab. Made a local run for 25 times, got no single failure. BUG=http://crbug.com/21108 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25614

Patch Set 1 #

Total comments: 4

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -6 lines)			Patch
M	chrome/browser/debugger/devtools_sanity_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/data/devtools/js_page.html	View	1 chunk	+15 lines, -2 lines	4 comments	Download
M	webkit/glue/devtools/js/tests.js	View	2 chunks	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

LGTM http://codereview.chromium.org/200040/diff/1/3 File chrome/test/data/devtools/js_page.html (right): http://codereview.chromium.org/200040/diff/1/3#newcode9 Line 9: var started = (new Date()).getTime(); Use Date.now(); ...

11 years, 3 months ago (2009-09-08 09:46:27 UTC) #2

mnaganov (inactive)

11 years, 3 months ago (2009-09-08 09:49:23 UTC) #3

http://codereview.chromium.org/200040/diff/1/3
File chrome/test/data/devtools/js_page.html (right):

http://codereview.chromium.org/200040/diff/1/3#newcode9
Line 9: var started = (new Date()).getTime();
On 2009/09/08 09:46:28, Yury Semikhatsky wrote:
> Use Date.now(); instead

Thanks! Done.

http://codereview.chromium.org/200040/diff/1/3#newcode13
Line 13: if ((new Date()).getTime() - started >= 100) {
On 2009/09/08 09:46:28, Yury Semikhatsky wrote:
> ditto

Done.

Expand Messages | Collapse Messages