Issue 200039: DevTools: provisional support for scopes of type 'Catch'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200039: DevTools: provisional support for scopes of type 'Catch' (Closed)

Created:
11 years, 3 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
apavlov, mnaganov (inactive)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: provisional support for scopes of type 'Catch' introduced in v8 by http://codereview.chromium.org/202005 BUG=17229 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25613

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	webkit/glue/devtools/js/debugger_agent.js	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

LGTM with comment http://codereview.chromium.org/200039/diff/1/2 File webkit/glue/devtools/js/debugger_agent.js (right): http://codereview.chromium.org/200039/diff/1/2#newcode1050 Line 1050: case ScopeType.With: Please provide a ...

11 years, 3 months ago (2009-09-08 09:42:59 UTC) #2

yurys

11 years, 3 months ago (2009-09-08 09:48:50 UTC) #3

http://codereview.chromium.org/200039/diff/1/2
File webkit/glue/devtools/js/debugger_agent.js (right):

http://codereview.chromium.org/200039/diff/1/2#newcode1050
Line 1050: case ScopeType.With:
On 2009/09/08 09:42:59, Michail Naganov wrote:
> Please provide a comment that these cases are treated the same, and you
haven't
> forgot to insert 'break'.

Done.

Expand Messages | Collapse Messages

Issue 200039: DevTools: provisional support for scopes of type 'Catch' (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages