Allow the default browser check to return "unknown" and reflect that in the UI.

chrome/browser/shell_integration_linux.cc

Index: chrome/browser/shell_integration_linux.cc
===================================================================
--- chrome/browser/shell_integration_linux.cc	(revision 25499)
+++ chrome/browser/shell_integration_linux.cc	(working copy)
@@ -180,7 +180,7 @@
   return LaunchXdgUtility(argv);
 }
 
-bool ShellIntegration::IsDefaultBrowser() {
+ShellIntegration::DefaultBrowserState ShellIntegration::IsDefaultBrowser() {
   std::vector<std::string> argv;
   argv.push_back("xdg-settings");
   argv.push_back("check");
@@ -189,15 +189,12 @@
 
   std::string reply;
   if (!base::GetAppOutput(CommandLine(argv), &reply)) {
-    // If xdg-settings fails, we assume that we should pretend we're the default
-    // browser to avoid giving repeated prompts to set ourselves as the default.
-    // TODO(mdm): Really, being the default browser should be a ternary query:
-    // yes, no, and "don't know" so the UI can reflect this more accurately.
-    return true;
+    // xdg-settings failed: we can't determine or set the default browser.
+    return UNKNOWN_DEFAULT_BROWSER;
   }
 
   // Allow any reply that starts with "yes".
-  return reply.find("yes") == 0;
+  return (reply.find("yes") == 0) ? IS_DEFAULT_BROWSER : NOT_DEFAULT_BROWSER;

[Evan Martin, 2009/09/04 22:46:15]

I wonder what happens in non-english locales?  (Not relevant to this change,
just noticed it now.)

[Mike Mammarella, 2009/09/04 22:56:27]

I wrote the other end of this in xdg-settings. It does "echo yes" so no worries.
:)

 }
 
 bool ShellIntegration::IsFirefoxDefaultBrowser() {