Issue 200020: Improving GetFocusManager on Gtk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200020: Improving GetFocusManager on Gtk (Closed)

Created:
11 years, 3 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Improving the FocusManager::GetFocusManager method on Gtk. BUG=None TEST=Run the FocusManager unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25660

Patch Set 2 : Added FocusNativeView #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	chrome/chrome.gyp	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
	M	views/focus/focus_manager_gtk.cc	View	1	1 chunk	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jcampan

Your version of the GetFocusManager was better, using it now. Thanks!

11 years, 3 months ago (2009-09-04 17:52:40 UTC) #1

DaveMoore

http://codereview.chromium.org/200020/diff/1/3 File views/focus/focus_manager_gtk.cc (right): http://codereview.chromium.org/200020/diff/1/3#newcode19 Line 19: NOTIMPLEMENTED(); I also had an implementation for FocusNativeView(). ...

11 years, 3 months ago (2009-09-07 13:46:47 UTC) #2