Issue 200014: Modifies write() so that NULs are allowed within a string....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
11 years, 3 months ago by abdulla

Modified:
11 years, 3 months ago

Reviewers:
Christian Plesner Hansen, diakopter

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Modifies write() so that NULs are allowed within a string. This is required by the mandelbrot test in the language shootout.

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/d8.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Christian Plesner Hansen

Landed in http://code.google.com/p/v8/source/detail?r=2821.

11 years, 3 months ago (2009-09-04 07:50:36 UTC) #3

diakopter

This is wrong (and breaks print()/write()); the new line needs to be: fwrite(*str, 1, str.length(), ...

11 years, 3 months ago (2009-09-04 15:03:06 UTC) #4

diakopter

11 years, 3 months ago (2009-09-04 15:04:04 UTC) #5

This commit broke print()/write()... The new line needs to be

fwrite(*str, 1, str.length(), stdout);