Issue 200004: Print a backtrace when a test binary crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200004: Print a backtrace when a test binary crashes. (Closed)

Created:
11 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
agl, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Print a backtrace when a test binary crashes. For now only for POSIX, Windows to follow very soon. TEST=none http://crbug.com/20996 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25330

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	base/test_suite.h	View		3 chunks	+13 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Please review: agl: correctness and API misuses maruel: Just in case.

11 years, 3 months ago (2009-09-03 16:58:03 UTC) #1

agl

11 years, 3 months ago (2009-09-03 17:36:33 UTC) #3

LGTM

http://codereview.chromium.org/200004/diff/1/2
File base/test_suite.h (right):

http://codereview.chromium.org/200004/diff/1/2#newcode40
Line 40: StackTrace().PrintBacktrace();
Note that, if the crash happens at certain points, this will probably fail or
deadlock. (e.g. a crash in malloc which is still holding the heap lock).
However, it'll work for 99% of cases and that's probably good enough.

http://codereview.chromium.org/200004/diff/1/2#newcode139
Line 139: CHECK(signal(SIGBUS, &TestSuiteCrashHandler) != SIG_ERR);
SIGFPE is probably good too.

Expand Messages | Collapse Messages