Issue 1996011: Prepare push to trunk. We are now vorking on version 2.2.10.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1996011: Prepare push to trunk. We are now vorking on version 2.2.10. (Closed)

Created:
10 years, 7 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push to trunk. We are now vorking on version 2.2.10. Committed: http://code.google.com/p/v8/source/detail?r=4625

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	ChangeLog	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/1996011/diff/1/3 File ChangeLog (right): http://codereview.chromium.org/1996011/diff/1/3#newcode3 ChangeLog:3: Fixed allowing Object.create to be called with a ...

10 years, 7 months ago (2010-05-10 06:56:05 UTC) #2

Søren Thygesen Gjesse

10 years, 7 months ago (2010-05-10 07:03:27 UTC) #3

http://codereview.chromium.org/1996011/diff/1/3
File ChangeLog (right):

http://codereview.chromium.org/1996011/diff/1/3#newcode3
ChangeLog:3: Fixed  allowing Object.create to be called with a function (issue
697).
On 2010/05/10 06:56:05, Mads Ager wrote:
> two spaces after eachother.
> 
> Fixed allowing -> Allowed?

Changed "Fixed  allowing" to "Allow"

http://codereview.chromium.org/1996011/diff/1/3#newcode5
ChangeLog:5: Fixed bug with Date.parse returning a value when called on a non
date
On 2010/05/10 06:56:05, Mads Ager wrote:
> value -> non-NaN value?

Done.

Expand Messages | Collapse Messages