|
Make it possible to build DRT in a chromium checkout.
The problem was the circular gyp dependency between webkit.gyp
and WebKit.gyp:
webkit.gyp:pull_in_webkit_unit_tests -> WebKit.gyp -> webkit.gyp:webkit_support.
The fix is to move webkit_support into its own gyp file (like we do
in an webkit only checkout). We can't use the same gyp file for in-
chromium and in-webkit because we need to change the include path for
features.gypi. In gyp, variable expansion happens after includes
(otherwise you'd have to expand variables twice and they could change
values), so we can't use a single gyp file for this.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47012
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+53 lines, -30 lines) |
Patch |
|
M |
build/all.gyp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/app/locales/locales.gyp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome.gyp
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_browser.gypi
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_common.gypi
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_dll.gypi
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_renderer.gypi
|
View
|
1
2
3
4
5
6
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests.gypi
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/nacl.gypi
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/test/interactive_ui/interactive_ui_tests.gypi
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webkit/default_plugin/default_plugin.gyp
|
View
|
4
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
webkit/support/webkit_support.gyp
|
View
|
3
4
5
6
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
|
A |
webkit/support/webkit_support_in_chromium.gyp
|
View
|
2
3
4
5
6
|
1 chunk |
+22 lines, -0 lines |
0 comments
|
Download
|
|
M |
webkit/tools/test_shell/test_shell.gypi
|
View
|
1
2
3
|
3 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
webkit/webkit.gyp
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|