Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1995013: Make it possible to build DRT in a chromium checkout. (Closed)

Created:
10 years, 7 months ago by tony
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Make it possible to build DRT in a chromium checkout. The problem was the circular gyp dependency between webkit.gyp and WebKit.gyp: webkit.gyp:pull_in_webkit_unit_tests -> WebKit.gyp -> webkit.gyp:webkit_support. The fix is to move webkit_support into its own gyp file (like we do in an webkit only checkout). We can't use the same gyp file for in- chromium and in-webkit because we need to change the include path for features.gypi. In gyp, variable expansion happens after includes (otherwise you'd have to expand variables twice and they could change values), so we can't use a single gyp file for this. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47012

Patch Set 1 #

Patch Set 2 : add file #

Patch Set 3 : fix non-mac #

Patch Set 4 : fixes #

Patch Set 5 : fix win #

Patch Set 6 : win fix #

Total comments: 2

Patch Set 7 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -30 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/locales/locales.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/nacl.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/interactive_ui/interactive_ui_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/default_plugin/default_plugin.gyp View 4 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/support/webkit_support.gyp View 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download
A webkit/support/webkit_support_in_chromium.gyp View 2 3 4 5 6 1 chunk +22 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M webkit/webkit.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
This patch fixes the circular dependency, but it moves some library targets from webkit into ...
10 years, 7 months ago (2010-05-12 05:44:59 UTC) #1
darin (slow to review)
10 years, 7 months ago (2010-05-12 06:09:34 UTC) #2
LGTM

http://codereview.chromium.org/1995013/diff/11001/12012
File webkit/support/webkit_support.gyp (right):

http://codereview.chromium.org/1995013/diff/11001/12012#newcode6
webkit/support/webkit_support.gyp:6: # This file is the same as
webkit_support.gyp except it references
nit: webkit_support.gyp -> webkit_support_in_chromium.gyp

http://codereview.chromium.org/1995013/diff/11001/12013
File webkit/support/webkit_support_in_chromium.gyp (right):

http://codereview.chromium.org/1995013/diff/11001/12013#newcode9
webkit/support/webkit_support_in_chromium.gyp:9: #
webkit_support_in_chromium.gyp as well.
nit: webkit_support_in_chromium.gyp -> webkit_support.gyp

Powered by Google App Engine
This is Rietveld 408576698