Enable CheckRietveldTryJobExecution for git-cl.

Enable CheckRietveldTryJobExecution for git-cl.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46923

[jochen (gone - plz use gerrit), 2010-05-11 09:18:46]

please review.

Depends on http://codereview.chromium.org/2014011/

Since the result of get cl status --field=id can be either None or a number, I
cannot convert the field to an integer. That's why I changed the format to %s in
CheckRietveldTryJobExecution

[M-A Ruel, 2010-05-11 13:40:43]

http://codereview.chromium.org/1993008/diff/1/3
File depot_tools/presubmit_canned_checks.py (right):

http://codereview.chromium.org/1993008/diff/1/3#newcode424
depot_tools/presubmit_canned_checks.py:424: host_url, input_api.change.issue,
input_api.change.patchset)
The reason I explicitly used %d there was to enforce that these values were ints
so I'd rather fix git-cl-hooks instead. Otherwise things can be messy and it's
impossible to test all the different code paths.

The thing is that None and '' are False but 'None' is true.

[jochen (gone - plz use gerrit), 2010-05-11 14:26:52]

http://codereview.chromium.org/1993008/diff/1/3
File depot_tools/presubmit_canned_checks.py (right):

http://codereview.chromium.org/1993008/diff/1/3#newcode424
depot_tools/presubmit_canned_checks.py:424: host_url, input_api.change.issue,
input_api.change.patchset)
On 2010/05/11 13:40:43, Marc-Antoine Ruel wrote:
> The reason I explicitly used %d there was to enforce that these values were
ints
> so I'd rather fix git-cl-hooks instead. Otherwise things can be messy and it's
> impossible to test all the different code paths.
> 
> The thing is that None and '' are False but 'None' is true.

Done.

[M-A Ruel, 2010-05-11 14:28:54]

http://codereview.chromium.org/1993008/diff/5001/6001
File depot_tools/git_cl_hooks.py (right):

http://codereview.chromium.org/1993008/diff/5001/6001#newcode54
depot_tools/git_cl_hooks.py:54: description =
gcl.GetIssueDescription(int(issue))
issue is already a int. You should check for None and not catch exceptions
instead.

[jochen (gone - plz use gerrit), 2010-05-11 14:54:09]

http://codereview.chromium.org/1993008/diff/5001/6001
File depot_tools/git_cl_hooks.py (right):

http://codereview.chromium.org/1993008/diff/5001/6001#newcode54
depot_tools/git_cl_hooks.py:54: description =
gcl.GetIssueDescription(int(issue))
On 2010/05/11 14:28:55, Marc-Antoine Ruel wrote:
> issue is already a int. You should check for None and not catch exceptions
> instead.

Done.

[M-A Ruel, 2010-05-11 15:09:56]

lgtm