Issue 1992017: Fix Print Selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1992017: Fix Print Selection. (Closed)

Created:
10 years, 7 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, jam+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Fix Print Selection. (And re-enable it on Windows; other platforms need more work.) BUG=22937, 27621 TEST=Go to a suitable web page; select something; Ctrl-P to print; select "Selection" under "Page Range"; print; etc. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47157

Patch Set 1 #

Patch Set 2 : Merged ToT. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	chrome/renderer/print_web_view_helper.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	chrome/renderer/print_web_view_helper.cc	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

You are reenabling it on Mac too BTW so change the description. Does selecting images ...

10 years, 7 months ago (2010-05-13 16:17:14 UTC) #2

viettrungluu

On 2010/05/13 16:17:14, Marc-Antoine Ruel wrote: > You are reenabling it on Mac too BTW ...

10 years, 7 months ago (2010-05-13 16:46:29 UTC) #3

lgtm

Expand Messages | Collapse Messages