Issue 1992012: Support both TOS register combinations in inlined keyed load...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1992012: Support both TOS register combinations in inlined keyed load... (Closed)

Created:
10 years, 7 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Support both TOS register combinations in inlined keyed load When popping key and receiver for an inlined keyed load support either order of r0/r1. The possible swap to have key in r0 and receiver in r1 is postponed to the deferred code calling the keyed load IC. Committed: http://code.google.com/p/v8/source/detail?r=4634

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -9 lines)			Patch
M	src/arm/codegen-arm.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/codegen-arm.cc	View	1	2 chunks	+20 lines, -7 lines	0 comments	Download
M	src/arm/virtual-frame-arm.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/1992012/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/1992012/diff/1/2#newcode5452 src/arm/codegen-arm.cc:5452: // Ensure key in r0 and receiver in ...

10 years, 7 months ago (2010-05-10 12:06:10 UTC) #2

Søren Thygesen Gjesse

10 years, 7 months ago (2010-05-10 12:35:38 UTC) #3

http://codereview.chromium.org/1992012/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1992012/diff/1/2#newcode5452
src/arm/codegen-arm.cc:5452: // Ensure key in r0 and receiver in r1 to match
keyel load ic calling
On 2010/05/10 12:06:10, Erik Corry wrote:
> keyel -> keyed

Done.

http://codereview.chromium.org/1992012/diff/1/2#newcode5455
src/arm/codegen-arm.cc:5455: __ Swap(r0, r1);
On 2010/05/10 12:06:10, Erik Corry wrote:
> The three-argument Swap is probably faster on a register-renaming ARM chip. 
> Perhaps we should get rid of the 2-argument xor-based one.

Changed to Swap(r0, r1, ip).

Expand Messages | Collapse Messages