Issue 1992011: Make X64 double-to-int32 conversion use the 64-bit version of cvttsd2si.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1992011: Make X64 double-to-int32 conversion use the 64-bit version of cvttsd2si. (Closed)

Created:
10 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

Make X64 double-to-int32 conversion use the 64-bit version of cvttsd2si. Use type info to allow ia32 to use the 32-bit versions in some cases. Remove sse3-specific code from X64 GenericBinaryOpStub.

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -136 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	1 chunk	+8 lines, -0 lines	2 comments	Download
M	src/x64/assembler-x64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.h	View	5 chunks	+1 line, -5 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	9 chunks	+19 lines, -131 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. Add a comment to the CL description that this removes the only use of ...

10 years, 7 months ago (2010-05-10 11:08:43 UTC) #2

Lasse Reichstein

10 years, 7 months ago (2010-05-10 11:20:44 UTC) #3

Updated description to mention removal of sse3 code.

http://codereview.chromium.org/1992011/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/1992011/diff/1/2#newcode10210
src/ia32/codegen-ia32.cc:10210: // Do some testing to see that the type info is
correct.
Removed (I meant to but forgot, well spotted).

Expand Messages | Collapse Messages