Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1992006: Do right-alignment of popups when WebKit indicates to do so. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host_view_mac.mm
===================================================================
--- chrome/browser/renderer_host/render_widget_host_view_mac.mm (revision 47162)
+++ chrome/browser/renderer_host/render_widget_host_view_mac.mm (working copy)
@@ -464,7 +464,8 @@
int item_height,
double item_font_size,
int selected_item,
- const std::vector<WebMenuItem>& items) {
+ const std::vector<WebMenuItem>& items,
+ bool right_aligned) {
is_popup_menu_ = true;
// Retain the Cocoa view for the duration of the pop-up so that it can't
@@ -483,7 +484,8 @@
// Display the menu.
scoped_nsobject<WebMenuRunner> menu_runner;
menu_runner.reset([[WebMenuRunner alloc] initWithItems:items
- fontSize:item_font_size]);
+ fontSize:item_font_size
+ rightAligned:right_aligned]);
{
// Make sure events can be pumped while the menu is up.
@@ -1041,7 +1043,8 @@
return;
}
- DCHECK(renderWidgetHostView_->render_widget_host_->process()->HasConnection());
+ DCHECK(
+ renderWidgetHostView_->render_widget_host_->process()->HasConnection());
DCHECK(!renderWidgetHostView_->about_to_validate_and_paint_);
renderWidgetHostView_->about_to_validate_and_paint_ = true;
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_mac.h ('k') | chrome/browser/renderer_host/test/test_render_view_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698