Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: chrome/browser/renderer_host/render_widget_host.cc

Issue 1992006: Do right-alignment of popups when WebKit indicates to do so. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host_view.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/render_widget_host.h" 5 #include "chrome/browser/renderer_host/render_widget_host.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/histogram.h" 8 #include "base/histogram.h"
9 #include "base/keyboard_codes.h" 9 #include "base/keyboard_codes.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 899 matching lines...) Expand 10 before | Expand all | Expand 10 after
910 } 910 }
911 911
912 #elif defined(OS_MACOSX) 912 #elif defined(OS_MACOSX)
913 913
914 void RenderWidgetHost::OnMsgShowPopup( 914 void RenderWidgetHost::OnMsgShowPopup(
915 const ViewHostMsg_ShowPopup_Params& params) { 915 const ViewHostMsg_ShowPopup_Params& params) {
916 view_->ShowPopupWithItems(params.bounds, 916 view_->ShowPopupWithItems(params.bounds,
917 params.item_height, 917 params.item_height,
918 params.item_font_size, 918 params.item_font_size,
919 params.selected_item, 919 params.selected_item,
920 params.popup_items); 920 params.popup_items,
921 params.right_aligned);
921 } 922 }
922 923
923 void RenderWidgetHost::OnMsgGetScreenInfo(gfx::NativeViewId view, 924 void RenderWidgetHost::OnMsgGetScreenInfo(gfx::NativeViewId view,
924 WebScreenInfo* results) { 925 WebScreenInfo* results) {
925 gfx::NativeView native_view = view_ ? view_->GetNativeView() : NULL; 926 gfx::NativeView native_view = view_ ? view_->GetNativeView() : NULL;
926 *results = WebScreenInfoFactory::screenInfo(native_view); 927 *results = WebScreenInfoFactory::screenInfo(native_view);
927 } 928 }
928 929
929 void RenderWidgetHost::OnMsgGetWindowRect(gfx::NativeViewId window_id, 930 void RenderWidgetHost::OnMsgGetWindowRect(gfx::NativeViewId window_id,
930 gfx::Rect* results) { 931 gfx::Rect* results) {
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
1097 // of this key event. 1098 // of this key event.
1098 if (!processed && !is_hidden_ && !front_item.skip_in_browser) { 1099 if (!processed && !is_hidden_ && !front_item.skip_in_browser) {
1099 UnhandledKeyboardEvent(front_item); 1100 UnhandledKeyboardEvent(front_item);
1100 1101
1101 // WARNING: This RenderWidgetHost can be deallocated at this point 1102 // WARNING: This RenderWidgetHost can be deallocated at this point
1102 // (i.e. in the case of Ctrl+W, where the call to 1103 // (i.e. in the case of Ctrl+W, where the call to
1103 // UnhandledKeyboardEvent destroys this RenderWidgetHost). 1104 // UnhandledKeyboardEvent destroys this RenderWidgetHost).
1104 } 1105 }
1105 } 1106 }
1106 } 1107 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698