Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/plugin_updater_unittest.cc

Issue 1991005: (1) Group plugins with the same name together. (2) Show a download link for p... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/plugin_updater.cc ('k') | chrome/browser/resources/plugins.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Property Changes:
Added: svn:eol-style
+ LF
OLDNEW
(Empty)
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/plugin_updater.h"
6
7 #include <string>
8 #include <vector>
9
10 #include "base/scoped_ptr.h"
11 #include "base/string_util.h"
12 #include "base/version.h"
13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "webkit/glue/plugins/webplugininfo.h"
15
16 static const PluginGroupDefinition kPluginDef = {
17 "MyPlugin", "MyPlugin", "", "", "3.0.44", "http://latest/" };
18 static const PluginGroupDefinition kPluginDef3 = {
19 "MyPlugin 3", "MyPlugin", "0", "4", "3.0.44", "http://latest" };
20 static const PluginGroupDefinition kPluginDef4 = {
21 "MyPlugin 4", "MyPlugin", "4", "5", "4.0.44", "http://latest" };
22 static const PluginGroupDefinition kPluginDefNotVulnerable = {
23 "MyPlugin", "MyPlugin", "", "", "", "http://latest" };
24
25 // name, path, version, desc, mime_types, enabled.
26 static WebPluginInfo kPlugin2043 = {
27 L"MyPlugin", FilePath(), L"2.0.43", L"",
28 std::vector<WebPluginMimeType>(), true };
29 static WebPluginInfo kPlugin3043 = {
30 L"MyPlugin", FilePath(), L"3.0.43", L"",
31 std::vector<WebPluginMimeType>(), true };
32 static WebPluginInfo kPlugin3044 = {
33 L"MyPlugin", FilePath(), L"3.0.44", L"",
34 std::vector<WebPluginMimeType>(), true };
35 static WebPluginInfo kPlugin3045 = {
36 L"MyPlugin", FilePath(), L"3.0.45", L"",
37 std::vector<WebPluginMimeType>(), true };
38 static WebPluginInfo kPlugin4043 = {
39 L"MyPlugin", FilePath(), L"4.0.43", L"",
40 std::vector<WebPluginMimeType>(), true };
41
42 class PluginUpdaterTest : public testing::Test {
43 };
44
45 TEST(PluginUpdaterTest, PluginGroupMatch) {
46 scoped_ptr<PluginGroup> group(PluginGroup::FromPluginGroupDefinition(
47 kPluginDef3));
48 EXPECT_TRUE(group->Match(kPlugin3045));
49 group->AddPlugin(kPlugin3045, 0);
50 EXPECT_FALSE(group->IsVulnerable());
51 }
52
53 TEST(PluginUpdaterTest, PluginGroupMatchMultipleFiles) {
54 scoped_ptr<PluginGroup> group(PluginGroup::FromPluginGroupDefinition(
55 kPluginDef3));
56 EXPECT_TRUE(group->Match(kPlugin3043));
57 group->AddPlugin(kPlugin3043, 0);
58 EXPECT_TRUE(group->IsVulnerable());
59
60 EXPECT_TRUE(group->Match(kPlugin3045));
61 group->AddPlugin(kPlugin3045, 1);
62 EXPECT_FALSE(group->IsVulnerable());
63 }
64
65 TEST(PluginUpdaterTest, PluginGroupMatchCorrectVersion) {
66 scoped_ptr<PluginGroup> group(PluginGroup::FromPluginGroupDefinition(
67 kPluginDef3));
68 EXPECT_TRUE(group->Match(kPlugin2043));
69 EXPECT_TRUE(group->Match(kPlugin3043));
70 EXPECT_FALSE(group->Match(kPlugin4043));
71
72 group.reset(PluginGroup::FromPluginGroupDefinition(kPluginDef4));
73 EXPECT_FALSE(group->Match(kPlugin2043));
74 EXPECT_FALSE(group->Match(kPlugin3043));
75 EXPECT_TRUE(group->Match(kPlugin4043));
76 }
77
78 TEST(PluginUpdaterTest, PluginGroupDefinition) {
79 const PluginGroupDefinition* definitions =
80 PluginUpdater::GetPluginGroupDefinitions();
81 for (size_t i = 0; i < PluginUpdater::GetPluginGroupDefinitionsSize(); ++i) {
82 scoped_ptr<PluginGroup> def_group(
83 PluginGroup::FromPluginGroupDefinition(definitions[i]));
84 ASSERT_TRUE(def_group.get() != NULL);
85 EXPECT_FALSE(def_group->Match(kPlugin2043));
86 }
87 }
88
89 TEST(PluginUpdaterTest, VersionExtraction) {
90 // Some real-world plugin versions (spaces, commata, parentheses, 'r', oh my)
91 const char* versions[][2] = {
92 { "7.6.6 (1671)", "7.6.6.1671" }, // Quicktime
93 { "2, 0, 0, 254", "2.0.0.254" }, // DivX
94 { "3, 0, 0, 0", "3.0.0.0" }, // Picasa
95 { "1, 0, 0, 1", "1.0.0.1" }, // Earth
96 { "10,0,45,2", "10.0.45.2" }, // Flash
97 { "11.5.7r609", "11.5.7.609"} // Shockwave
98 };
99
100 for (size_t i = 0; i < arraysize(versions); i++) {
101 const WebPluginInfo plugin = {
102 L"Blah Plugin", FilePath(), ASCIIToWide(versions[i][0]), L"",
103 std::vector<WebPluginMimeType>(), true };
104 scoped_ptr<PluginGroup> group(PluginGroup::FromWebPluginInfo(plugin));
105 EXPECT_TRUE(group->Match(plugin));
106 group->AddPlugin(plugin, 0);
107 scoped_ptr<DictionaryValue> data(group->GetData());
108 std::string version;
109 data->GetString(L"version", &version);
110 EXPECT_EQ(versions[i][1], version);
111 }
112 }
OLDNEW
« no previous file with comments | « chrome/browser/plugin_updater.cc ('k') | chrome/browser/resources/plugins.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698