Allow windows with a single tab to be merged into other windows with drag and...

Allow windows with a single tab to be merged into other windows with drag and drop. When there is a single window with a single tab, we treat it like a window move.
BUG=15108
TEST=dragging out windows and merging them back in, dragging windows around to move them. Test windows of different types (incognito) as well.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25894

[rohitrao (ping after 24h), 2009-09-10 19:03:56]

LGTM

http://codereview.chromium.org/199079/diff/1/2
File chrome/browser/cocoa/tab_view.mm (left):

http://codereview.chromium.org/199079/diff/1/2#oldcode401
Line 401: [targets removeAllObjects];
This is ok to delete because targets is never referenced again?

http://codereview.chromium.org/199079/diff/1/2
File chrome/browser/cocoa/tab_view.mm (right):

http://codereview.chromium.org/199079/diff/1/2#newcode226
Line 226: ![self canBeDragged];
Should this be in line with the "(" above?

[pink (ping after 24hrs), 2009-09-10 19:05:55]

http://codereview.chromium.org/199079/diff/1/2
File chrome/browser/cocoa/tab_view.mm (left):

http://codereview.chromium.org/199079/diff/1/2#oldcode401
Line 401: [targets removeAllObjects];
On 2009/09/10 19:03:56, rohitrao wrote:
> This is ok to delete because targets is never referenced again?

Correct. It must have been leftover from something else.

http://codereview.chromium.org/199079/diff/1/2
File chrome/browser/cocoa/tab_view.mm (right):

http://codereview.chromium.org/199079/diff/1/2#newcode226
Line 226: ![self canBeDragged];
On 2009/09/10 19:03:56, rohitrao wrote:
> Should this be in line with the "(" above?

No, the first two should bind together, or'd with the last expression.

[pink (ping after 24hrs), 2009-09-10 19:06:30]

http://codereview.chromium.org/199079/diff/1/2
File chrome/browser/cocoa/tab_view.mm (right):

http://codereview.chromium.org/199079/diff/1/2#newcode226
Line 226: ![self canBeDragged];
Oops, my bad, yes. Misunderstood.