Issue 199077: Reapplies the GdkPixbuf -> cairo surface patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199077: Reapplies the GdkPixbuf -> cairo surface patch. (Closed)

Created:
11 years, 3 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Reapplies the GdkPixbuf -> cairo surface patch. Only difference is explicitly calling a FreePerDisplaySurfaces() function from ~GtkThemeProvider() because vtables are set to base class during destructor calling. BUG=http://crbug.com/10499 Original Review URL: http://codereview.chromium.org/197046 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25880

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+309 lines, -117 lines)			Patch
M	chrome/browser/browser_theme_provider.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_bar_gtk.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	10 chunks	+42 lines, -45 lines	0 comments	Download
A	chrome/browser/gtk/cairo_cached_surface.h	View	1 chunk	+57 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/cairo_cached_surface.cc	View	1 chunk	+68 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/custom_button.h	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/custom_button.cc	View	7 chunks	+50 lines, -39 lines	0 comments	Download
M	chrome/browser/gtk/find_bar_gtk.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/gtk/go_button_gtk.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/gtk/gtk_theme_provider.h	View	6 chunks	+22 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/gtk_theme_provider.cc	View	5 chunks	+38 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/toolbar_star_toggle_gtk.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Elliot Glaysher

The only differences are in gtk_theme_provider.{cc,h}. The patch is identical otherwise.

11 years, 3 months ago (2009-09-10 17:50:41 UTC) #2

OK, LGTM