Issue 199067: Use base::WindowImpl instead of CWindowImpl to remove a dependency on ATL....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199067: Use base::WindowImpl instead of CWindowImpl to remove a dependency on ATL.... (Closed)

Created:
11 years, 3 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use base::WindowImpl instead of CWindowImpl to remove a dependency on ATL. BUG=5027 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25799

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -62 lines)			Patch
	M	views/controls/scrollbar/native_scroll_bar.cc	View	1	12 chunks	+38 lines, -62 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

11 years, 3 months ago (2009-09-09 21:33:14 UTC) #2

LGTM

http://codereview.chromium.org/199067/diff/1/2
File views/controls/scrollbar/native_scroll_bar.cc (right):

http://codereview.chromium.org/199067/diff/1/2#newcode74
Line 74: scrollbar_ = CreateWindow(L"SCROLLBAR",
Nit: This wrapping style is pretty unusual.  Feel free to collapse all the
instances of it in this file.

Expand Messages | Collapse Messages