DevTools: add setting/setSetting methods to InspectorController in front-end

webkit/glue/devtools/js/inspector_controller_impl.js

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview DevTools' implementation of the InspectorController API.
  */
 goog.require('devtools.InspectorController');
 
 goog.provide('devtools.InspectorControllerImpl');
 
 devtools.InspectorControllerImpl = function() {
   devtools.InspectorController.call(this);
   this.frame_element_id_ = 1;
 
   this.installInspectorControllerDelegate_('clearMessages');
   this.installInspectorControllerDelegate_('storeLastActivePanel');
   this.installInspectorControllerDelegate_('highlightDOMNode');
   this.installInspectorControllerDelegate_('hideDOMNodeHighlight');
   this.installInspectorControllerDelegate_('getChildNodes');
   this.installInspectorControllerDelegate_('setAttribute');
   this.installInspectorControllerDelegate_('removeAttribute');
   this.installInspectorControllerDelegate_('setTextNodeValue');
   this.installInspectorControllerDelegate_('enableResourceTracking');
   this.installInspectorControllerDelegate_('disableResourceTracking');
   this.installInspectorControllerDelegate_('enableTimeline');
   this.installInspectorControllerDelegate_('disableTimeline');
-
-  //TODO: nuke with the next WebKit roll.
-  this.installInjectedScriptDelegate_('getStyles');
-  this.installInjectedScriptDelegate_('getComputedStyle');
-  this.installInjectedScriptDelegate_('getInlineStyle');
-  this.installInjectedScriptDelegate_('applyStyleText');
-  this.installInjectedScriptDelegate_('setStyleText');
-  this.installInjectedScriptDelegate_('toggleStyleEnabled');
-  this.installInjectedScriptDelegate_('applyStyleRuleText');
-  this.installInjectedScriptDelegate_('addStyleSelector');
-  this.installInjectedScriptDelegate_('setStyleProperty');
-  this.installInjectedScriptDelegate_('getPrototypes');
-  this.installInjectedScriptDelegate_('setPropertyValue');
-  this.installInjectedScriptDelegate_('evaluate');
-  this.installInjectedScriptDelegate_('addInspectedNode');
-  this.installInjectedScriptDelegate_('pushNodeToFrontend');
-  this.installInjectedScriptDelegate_('performSearch');
-  this.installInjectedScriptDelegate_('searchCanceled');
-  this.installInjectedScriptDelegate_('openInInspectedWindow');
+  this.installInspectorControllerDelegate_('setting');

[pfeldman, 2009/11/18 16:58:19]

Hm... How is setting supposed to return the value over the process boundary?

+  this.installInspectorControllerDelegate_('setSetting');
 };
 goog.inherits(devtools.InspectorControllerImpl,
     devtools.InspectorController);
 
 
 /**
  * {@inheritDoc}.
  */
 devtools.InspectorControllerImpl.prototype.platform = function() {
   return DevToolsHost.getPlatform();
@@ skipping 223 matching lines @@
         isException);
   };
   RemoteToolsAgent.ExecuteUtilityFunction(
       devtools.Callback.wrap(callback),
       'InjectedScript',
       JSON.stringify(['dispatch', methodName, argsString]));
 };
 
 
 /**
- * TODO: nuke with the next WebKit roll.
- * Installs delegating handler into the inspector controller.
- * @param {string} methodName Method to install delegating handler for.
- */
-devtools.InspectorControllerImpl.prototype.installInjectedScriptDelegate_ =
-    function(methodName) {
-  this[methodName] = goog.bind(this.callInjectedScript_, this,
-      methodName);
-};
-
-
-/**
- * TODO: nuke with the next WebKit roll.
- * Bound function with the installInjectedScriptDelegate_ actual
- * implementation.
+ * This method allows calling a methods on InjectedScript object in the
+ * inspected page.
  */
 devtools.InspectorControllerImpl.prototype.callInjectedScript_ =
     function(methodName, var_arg) {
   var allArgs = Array.prototype.slice.call(arguments);
   var callback = allArgs[allArgs.length - 1];
   var args = Array.prototype.slice.call(allArgs, 0, allArgs.length - 1);
   RemoteToolsAgent.ExecuteUtilityFunction(
       devtools.InspectorControllerImpl.parseWrap_(callback),
       'InjectedScript', JSON.stringify(args));
 };
@@ skipping 25 matching lines @@
 
 devtools.InspectorControllerImpl.parseWrap_ = function(callback) {
   return devtools.Callback.wrap(
       function(data) {
         callback.call(this, JSON.parse(data));
       });
 };
 
 
 InspectorController = new devtools.InspectorControllerImpl();