Issue 199054: GTK: fix tabstrip index misalignment during tab removal....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199054: GTK: fix tabstrip index misalignment during tab removal.... (Closed)

Created:
11 years, 3 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
James Hawkins, Evan Martin

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: fix tabstrip index misalignment during tab removal. Repro steps: - open a gmail tab and get someone to message you such that the tab title keeps changing - put that tab to the right of a bunch of other tabs - close a bunch of the tabs to the left of gmail Each time you close a tab you have about a 10% chance of reproing. The solution is essentially copy-pasted from the windows tabstrip. The Browser change is somewhat unrelated. I noticed the comment "Do not dereference |contents|" and that we were in fact dereferncing |contents|, so I worked around it. BUG=13811

Patch Set 1 #

Patch Set 2 : remove debugging code #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -3 lines)			Patch
M	chrome/browser/browser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/tabs/tab_strip_gtk.h	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/tabs/tab_strip_gtk.cc	View	2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages