Issue 199050: Wires up drag and drop for bookmark menus and cleans up a couple of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199050: Wires up drag and drop for bookmark menus and cleans up a couple of... (Closed)

Created:
11 years, 3 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Wires up drag and drop for bookmark menus and cleans up a couple of minor painting issues. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25701

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -27 lines)			Patch
M	chrome/browser/views/bookmark_menu_controller_views.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/views/bookmark_menu_controller_views.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	views/controls/menu/menu_config_gtk.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/controls/menu/menu_controller.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	views/controls/menu/menu_controller.cc	View	3 chunks	+16 lines, -14 lines	0 comments	Download
M	views/controls/menu/menu_delegate.h	View	2 chunks	+16 lines, -2 lines	1 comment	Download
M	views/controls/menu/menu_scroll_view_container.cc	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	views/controls/menu/menu_separator_gtk.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	views/controls/menu/submenu_view.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	views/controls/menu/submenu_view.cc	View	1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jcampan

11 years, 3 months ago (2009-09-08 20:27:36 UTC) #2

LGTM

http://codereview.chromium.org/199050/diff/1/3
File views/controls/menu/menu_delegate.h (right):

http://codereview.chromium.org/199050/diff/1/3#newcode112
Line 112: 
Nit: remove empty line

Expand Messages | Collapse Messages