Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 199044: Allign Intel macro assemblers with changes to ARM macro assembler (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Allign Intel macro assemblers with changes to ARM macro assembler. Removed bogus ASSERTs from Intel macro assemblers. Added a debug mode generated code assert to allocation code. Committed: http://code.google.com/p/v8/source/detail?r=2837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M src/ia32/builtins-ia32.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 3 months ago (2009-09-07 11:10:10 UTC) #1
Erik Corry
11 years, 3 months ago (2009-09-07 11:13:43 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698