Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 199043: Const Correctness for String::Value (Closed)

Created:
11 years, 3 months ago by paroga
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Const Correctness for String::Value BUG=378

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M include/v8.h View 1 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Christian Plesner Hansen
Lgtm
11 years, 3 months ago (2009-09-07 07:45:02 UTC) #1
Christian Plesner Hansen
Landed in http://code.google.com/p/v8/source/detail?r=2831.
11 years, 3 months ago (2009-09-07 07:55:23 UTC) #2
Christian Plesner Hansen
Also: thanks for the patch!
11 years, 3 months ago (2009-09-07 07:55:54 UTC) #3
paroga
the const modifier of the String::Value-class was wrong
11 years, 3 months ago (2009-09-07 18:04:18 UTC) #4
Christian Plesner Hansen
11 years, 3 months ago (2009-09-09 09:39:18 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698