chrome/browser/views/tabs/tab_strip.cc - Issue 199025: Fix some gcc 4.4 issues when compiling with toolkit_views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/tabs/tab_strip.cc

Issue 199025: Fix some gcc 4.4 issues when compiling with toolkit_views. (Closed)

Patch Set: Remove CreateFindBar, use COMPILER_GCC and add comments. Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/views/tabs/tab_strip.cc

diff --git a/chrome/browser/views/tabs/tab_strip.cc b/chrome/browser/views/tabs/tab_strip.cc

index 3ff6d456bc98da5589ae3a4b2eb3a470a332f399..d615e7a1e645565ea8cb254c75154b42b822e4d4 100644

--- a/chrome/browser/views/tabs/tab_strip.cc

+++ b/chrome/browser/views/tabs/tab_strip.cc

@@ -36,6 +36,12 @@

#undef min

#undef max

+#if defined(COMPILER_GCC)

+// Squash false positive signed overflow warning in GenerateStartAndEndWidths

+// when doing 'start_tab_count < end_tab_count'.

+#pragma GCC diagnostic ignored "-Wstrict-overflow"

+#endif

using views::DropTargetEvent;

static const int kDefaultAnimationDurationMs = 100;

« no previous file with comments | « chrome/browser/views/dialog_stubs_gtk.cc ('k') | chrome/chrome.gyp » ('j') | no next file with comments »