Issue 199020: Fix TextInputController::insertText() so that it celar selected text before i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199020: Fix TextInputController::insertText() so that it celar selected text before i... (Closed)

Created:
11 years, 3 months ago by tkent

Modified:
9 years, 7 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, Victor Wang

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix TextInputController::insertText() so that it clear selected text before insertion. TEST=none BUG=20993

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	webkit/tools/test_shell/text_input_controller.cc	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Thank you for your change. Even though it looks good to me, I would like ...

11 years, 3 months ago (2009-09-04 07:06:10 UTC) #2

tkent

http://codereview.chromium.org/199020/diff/2001/3002 File webkit/tools/test_shell/text_input_controller.cc (right): http://codereview.chromium.org/199020/diff/2001/3002#newcode57 Line 57: main_frame->replaceSelection(WebString()); On 2009/09/04 07:06:10, hbono wrote: > nit: ...

11 years, 3 months ago (2009-09-04 07:46:08 UTC) #3

Hironori Bono

11 years, 3 months ago (2009-09-04 11:35:19 UTC) #4

LGTM.
I think this is my expected behavior of our unmarkText() implementation since it
calls confirmCompositionWithoutDisturbingSelection().
Thank you for your investigation and update.

Regards,

Hironori Bono

Expand Messages | Collapse Messages

Issue 199020: Fix TextInputController::insertText() so that it celar selected text before i... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages