Add a disable button to the Extension management UI.

Add a disable button to the Extension management UI.

TEST=Try installing and/or loading some extensions, and toggling between enable and disable in the management UI (chrome://extensions).
BUG=12122
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25659

[Erik does not do reviews, 2009-09-04 00:05:36]

LGTM

http://codereview.chromium.org/199018/diff/1/5
File chrome/browser/extensions/extensions_service.h (right):

http://codereview.chromium.org/199018/diff/1/5#newcode134
Line 134: // TODO(mpcomplete): add DisableExtension.
remove TODO and update the rest of the comment.

http://codereview.chromium.org/199018/diff/1/6
File chrome/browser/extensions/extensions_ui.cc (right):

http://codereview.chromium.org/199018/diff/1/6#newcode169
Line 169: CHECK(list->GetSize() == 2);
I know this isn't really an issue with this particular change, but shouldn't the
reaction to bad arguments be to kill the renderer rather than killing the
browser process?

[Matt Perry, 2009-09-04 00:12:51]

http://codereview.chromium.org/199018/diff/1/5
File chrome/browser/extensions/extensions_service.h (right):

http://codereview.chromium.org/199018/diff/1/5#newcode134
Line 134: // TODO(mpcomplete): add DisableExtension.
On 2009/09/04 00:05:36, Erik Kay wrote:
> remove TODO and update the rest of the comment.

Done.

http://codereview.chromium.org/199018/diff/1/6
File chrome/browser/extensions/extensions_ui.cc (right):

http://codereview.chromium.org/199018/diff/1/6#newcode169
Line 169: CHECK(list->GetSize() == 2);
On 2009/09/04 00:05:36, Erik Kay wrote:
> I know this isn't really an issue with this particular change, but shouldn't
the
> reaction to bad arguments be to kill the renderer rather than killing the
> browser process?

Yeah. I think in this case, the renderer is displaying chrome-generated content
(the management UI), so it's a development-time assertion.

[Erik does not do reviews, 2009-09-04 00:32:55]

On Thu, Sep 3, 2009 at 5:12 PM, <mpcomplete@chromium.org> wrote:
>
> http://codereview.chromium.org/199018/diff/1/5
> File chrome/browser/extensions/extensions_service.h (right):
>
> http://codereview.chromium.org/199018/diff/1/5#newcode134
> Line 134: // TODO(mpcomplete): add DisableExtension.
> On 2009/09/04 00:05:36, Erik Kay wrote:
>>
>> remove TODO and update the rest of the comment.
>
> Done.
>
> http://codereview.chromium.org/199018/diff/1/6
> File chrome/browser/extensions/extensions_ui.cc (right):
>
> http://codereview.chromium.org/199018/diff/1/6#newcode169
> Line 169: CHECK(list->GetSize() == 2);
> On 2009/09/04 00:05:36, Erik Kay wrote:
>>
>> I know this isn't really an issue with this particular change, but
>
> shouldn't the
>>
>> reaction to bad arguments be to kill the renderer rather than killing
>
> the
>>
>> browser process?
>
> Yeah. I think in this case, the renderer is displaying chrome-generated
> content (the management UI), so it's a development-time assertion.

If it's meant to be development time only, then it could just be a
DCHECK.  I was assuming we were using CHECK for some security reason
on top of that.

Erik