Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 199016: linux: improve support for cross-compiling (Closed)

Created:
11 years, 3 months ago by piman
Modified:
9 years, 7 months ago
Reviewers:
sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: improve support for cross-compiling This CL adds support for a 'sysroot' GYP define, that should point to the target root filesystem for cross-compilation. It passes that argument to the compiler and linker which uses it to prefix its hard-coded path (e.g. /usr/include) It also points pkg-config to look for package configs there, and rewrite the paths to be prefixed by 'sysroot' (since pkg-config doesn't do it itself) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25418

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -28 lines) Patch
M build/common.gypi View 3 chunks +12 lines, -1 line 0 comments Download
A build/linux/pkg-config-wrapper View 1 1 chunk +14 lines, -0 lines 0 comments Download
A build/linux/rewrite_dirs.py View 1 1 chunk +61 lines, -0 lines 0 comments Download
M build/linux/system.gyp View 9 chunks +39 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
11 years, 3 months ago (2009-09-03 23:23:05 UTC) #1
sgk
http://codereview.chromium.org/199016/diff/1/2 File build/common.gypi (left): http://codereview.chromium.org/199016/diff/1/2#oldcode769 Line 769: } white space at end-of-line? http://codereview.chromium.org/199016/diff/1/3 File build/linux/pkg-config-wrapper ...
11 years, 3 months ago (2009-09-03 23:49:35 UTC) #2
piman
http://codereview.chromium.org/199016/diff/1/2 File build/common.gypi (left): http://codereview.chromium.org/199016/diff/1/2#oldcode769 Line 769: } On 2009/09/03 23:49:35, sgk wrote: > white ...
11 years, 3 months ago (2009-09-04 00:09:10 UTC) #3
sgk
11 years, 3 months ago (2009-09-04 00:16:50 UTC) #4
lgtm

http://codereview.chromium.org/199016/diff/1/2
File build/common.gypi (left):

http://codereview.chromium.org/199016/diff/1/2#oldcode769
Line 769: }
On 2009/09/04 00:09:10, piman wrote:
> On 2009/09/03 23:49:35, sgk wrote:
> > white space at end-of-line?
> 
> It adds the missing LF at the end of the file. It got added automatically by
> vim, I can remove it if you want, but this is consistent with other files.
> 

No, consistency is good.  Just wanted to make sure it wasn't an oversight.

Powered by Google App Engine
This is Rietveld 408576698