Issue 1990012: ia32: Helper function for getting an element of a fixed array from object poi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1990012: ia32: Helper function for getting an element of a fixed array from object poi... (Closed)

Created:
10 years, 7 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
antonm

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ia32: Helper function for getting an element of a fixed array from object pointer and smi index. Committed: http://code.google.com/p/v8/source/detail?r=4643

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -36 lines)			Patch
M	src/ia32/codegen-ia32.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	10 chunks	+14 lines, -35 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

LGTM. Are you planning to do something like that for x64 and/or ARM? If not, ...

10 years, 7 months ago (2010-05-11 12:04:07 UTC) #2

Søren Thygesen Gjesse

10 years, 7 months ago (2010-05-11 13:26:32 UTC) #3

On 2010/05/11 12:04:07, antonm wrote:
> LGTM.
> 
> Are you planning to do something like that for x64 and/or ARM?  If not, I'd do
> it at least for x64.

I will look at porting it. On x64 the index should probably be an int32 and not
a smi. I will look at the usage patterns.

Expand Messages | Collapse Messages