The app launcher had a height of zero as it was not getting preferred size up...

The app launcher had a height of zero as it was not getting preferred size updates
notifications.
The wrong render was getting told to report preferred size updates.
We now make sure we enable preferred size notifications when the render view host is created.
Also removed a check for the view type in render_view.cc that was preventing us from
polling the preferred size for regular tabs. This check is not needed since the notifications
need to be explictly enabled and they are only enabled by extensions related render views (and
the app launcher).

TEST=Open the app launcher, it should display correctly.
BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46588

[Matt Perry, 2010-05-05 23:47:38]

http://codereview.chromium.org/1989002/diff/1/8
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/1989002/diff/1/8#newcode3827
chrome/renderer/render_view.cc:3827:
preferred_size_change_timer_.Start(TimeDelta::FromMilliseconds(10), this,
I remember not liking this polling when it first went in. Aaron, what happened
to the webkit change that would remove the need for this?

[Aaron Boodman, 2010-05-06 00:19:15]

On 2010/05/05 23:47:38, Matt Perry wrote:
> http://codereview.chromium.org/1989002/diff/1/8
> File chrome/renderer/render_view.cc (right):
> 
> http://codereview.chromium.org/1989002/diff/1/8#newcode3827
> chrome/renderer/render_view.cc:3827:
> preferred_size_change_timer_.Start(TimeDelta::FromMilliseconds(10), this,
> I remember not liking this polling when it first went in. Aaron, what happened
> to the webkit change that would remove the need for this?

Hard. Still not done.

[Aaron Boodman, 2010-05-06 00:20:21]

lgtm

[Nico, 2010-05-22 02:31:39]

This patch (surprisingly) made the renderer processes use a lot more cpu on the
mac ( http://crbug.com/44494 ).